Skip to content
This repository was archived by the owner on Mar 1, 2023. It is now read-only.

Video/Audio Machine#51

Open
leonardomso wants to merge 2 commits intomattpocock:masterfrom
leonardomso:master
Open

Video/Audio Machine#51
leonardomso wants to merge 2 commits intomattpocock:masterfrom
leonardomso:master

Conversation

@leonardomso
Copy link
Copy Markdown

@leonardomso leonardomso commented May 27, 2021

As discussed in the #47 issue, here's the pull request for the Video/Audio controls machine.

I still think there's a lot of room for improvement in this machine. I'd love to receive some feedback.

A few ideas that I think could be discussed:

  • Change the initial state of ready state for idle. There might be some use cases where people want to load the content but not auto-play it.
  • Add support for seek.
  • Add support for quality controls and subtitles as @mattpocock suggested.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mattpocock/xstate-catalogue/6jGjaLLpu8hsRMs8cQeYRdQDpqd2
✅ Preview: https://xstate-catalogue-git-fork-leonardomso-master-mattpocock.vercel.app

@tomByrer
Copy link
Copy Markdown

Thanks!
Should the discussion be in this PR thread, or back in the Issue?

@leonardomso
Copy link
Copy Markdown
Author

I think it would be fine if it was in this pull request. What are your thoughts about it so far, @tomByrer?

@christianchown
Copy link
Copy Markdown

What are your thoughts of putting the boolean context items in parallel states, as in https://xstate.js.org/viz/?gist=b9a8e4db654cea07fe2080bd56b6cdc7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants