This repository was archived by the owner on Mar 1, 2023. It is now read-only.
Video/Audio Machine#51
Open
leonardomso wants to merge 2 commits intomattpocock:masterfrom
leonardomso:master
Open
Video/Audio Machine#51leonardomso wants to merge 2 commits intomattpocock:masterfrom leonardomso:master
leonardomso wants to merge 2 commits intomattpocock:masterfrom
leonardomso:master
Conversation
…imple documentation.
feature-audio-machine
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mattpocock/xstate-catalogue/6jGjaLLpu8hsRMs8cQeYRdQDpqd2 |
|
Thanks! |
Author
|
I think it would be fine if it was in this pull request. What are your thoughts about it so far, @tomByrer? |
|
What are your thoughts of putting the boolean context items in parallel states, as in https://xstate.js.org/viz/?gist=b9a8e4db654cea07fe2080bd56b6cdc7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in the #47 issue, here's the pull request for the Video/Audio controls machine.
I still think there's a lot of room for improvement in this machine. I'd love to receive some feedback.
A few ideas that I think could be discussed:
readystate foridle. There might be some use cases where people want to load the content but not auto-play it.seek.