feat(ffi): Expose SqliteStoreBuilder::key in the FFI layer#6581
Open
jmartinesp wants to merge 1 commit into
Open
feat(ffi): Expose SqliteStoreBuilder::key in the FFI layer#6581jmartinesp wants to merge 1 commit into
SqliteStoreBuilder::key in the FFI layer#6581jmartinesp wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6581 +/- ##
==========================================
+ Coverage 89.93% 89.95% +0.02%
==========================================
Files 382 382
Lines 107797 107797
Branches 107797 107797
==========================================
+ Hits 96943 96967 +24
+ Misses 7174 7161 -13
+ Partials 3680 3669 -11 ☔ View full report in Codecov by Sentry. |
58657f7 to
0c655e0
Compare
This allows clients to provide a raw key instead of a passphrase for the key used to encrypt and decrypt data in the store DBs. Using a raw key with enough entropy should be safe, and we can skip the key derivation performed in the passphrase, which slows down session restoration (it's now 50% faster in my local tests).
0c655e0 to
d302f5f
Compare
Contributor
Author
|
Sorry, force pushed to fix a typo in the changelog file, there weren't any other changes in the rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows clients to provide a raw key instead of a passphrase for the key used to encrypt and decrypt data in the store DBs.
Using a raw key with enough entropy should be safe, and we can skip the key derivation performed in the passphrase, which slows down session restoration (it's now 50% faster in my local tests).
CHANGELOG.mdfiles.Signed-off-by: