Skip to content

feat(ffi): Expose SqliteStoreBuilder::key in the FFI layer#6581

Open
jmartinesp wants to merge 1 commit into
mainfrom
feat/ffi-expose-sqlite-store-builder-key
Open

feat(ffi): Expose SqliteStoreBuilder::key in the FFI layer#6581
jmartinesp wants to merge 1 commit into
mainfrom
feat/ffi-expose-sqlite-store-builder-key

Conversation

@jmartinesp
Copy link
Copy Markdown
Contributor

@jmartinesp jmartinesp commented May 18, 2026

This allows clients to provide a raw key instead of a passphrase for the key used to encrypt and decrypt data in the store DBs.

Using a raw key with enough entropy should be safe, and we can skip the key derivation performed in the passphrase, which slows down session restoration (it's now 50% faster in my local tests).

  • I've documented the public API Changes in the appropriate CHANGELOG.md files.
  • This PR was made with the help of AI.

Signed-off-by:

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.95%. Comparing base (56de50c) to head (d302f5f).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6581      +/-   ##
==========================================
+ Coverage   89.93%   89.95%   +0.02%     
==========================================
  Files         382      382              
  Lines      107797   107797              
  Branches   107797   107797              
==========================================
+ Hits        96943    96967      +24     
+ Misses       7174     7161      -13     
+ Partials     3680     3669      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 18, 2026

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing feat/ffi-expose-sqlite-store-builder-key (d302f5f) with main (b6d0f8a)

Open in CodSpeed

@jmartinesp jmartinesp force-pushed the feat/ffi-expose-sqlite-store-builder-key branch from 58657f7 to 0c655e0 Compare May 18, 2026 13:05
@jmartinesp jmartinesp marked this pull request as ready for review May 18, 2026 13:05
@jmartinesp jmartinesp requested a review from a team as a code owner May 18, 2026 13:05
@jmartinesp jmartinesp requested review from Hywan and removed request for a team May 18, 2026 13:05
This allows clients to provide a raw key instead of a passphrase for the key used to encrypt and decrypt data in the store DBs.

Using a raw key with enough entropy should be safe, and we can skip the key derivation performed in the passphrase, which slows down session restoration (it's now 50% faster in my local tests).
@jmartinesp jmartinesp force-pushed the feat/ffi-expose-sqlite-store-builder-key branch from 0c655e0 to d302f5f Compare May 18, 2026 13:20
@jmartinesp
Copy link
Copy Markdown
Contributor Author

jmartinesp commented May 18, 2026

Sorry, force pushed to fix a typo in the changelog file, there weren't any other changes in the rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant