Skip to content

Support for MSC4388 for the QR login#6173

Draft
poljar wants to merge 28 commits into
mainfrom
poljar/qr-login/msc4388
Draft

Support for MSC4388 for the QR login#6173
poljar wants to merge 28 commits into
mainfrom
poljar/qr-login/msc4388

Conversation

@poljar
Copy link
Copy Markdown
Contributor

@poljar poljar commented Feb 13, 2026

  • Public API changes documented in changelogs (optional)

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 93.59684% with 81 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.00%. Comparing base (1136eb4) to head (d8cd83f).
⚠️ Report is 65 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...cation/oauth/qrcode/rendezvous_channel/msc_4388.rs 94.76% 11 Missing and 6 partials ⚠️
...atrix-sdk/src/authentication/oauth/qrcode/grant.rs 92.69% 14 Missing and 2 partials ⚠️
...atrix-sdk/src/authentication/oauth/qrcode/login.rs 95.77% 10 Missing and 2 partials ⚠️
.../authentication/oauth/qrcode/secure_channel/mod.rs 93.42% 6 Missing and 4 partials ⚠️
...tion/oauth/qrcode/secure_channel/crypto_channel.rs 67.85% 0 Missing and 9 partials ⚠️
...hentication/oauth/qrcode/rendezvous_channel/mod.rs 88.00% 0 Missing and 6 partials ⚠️
...s/matrix-sdk-crypto/src/types/qr_login/msc_4388.rs 87.50% 3 Missing and 2 partials ⚠️
.../matrix-sdk/src/authentication/oauth/qrcode/mod.rs 96.89% 4 Missing ⚠️
crates/matrix-sdk-crypto/src/types/qr_login/mod.rs 71.42% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6173      +/-   ##
==========================================
+ Coverage   89.94%   90.00%   +0.06%     
==========================================
  Files         381      382       +1     
  Lines      105753   106793    +1040     
  Branches   105753   106793    +1040     
==========================================
+ Hits        95115    96121    +1006     
- Misses       6993     7013      +20     
- Partials     3645     3659      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Feb 13, 2026

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing poljar/qr-login/msc4388 (d8cd83f) with main (2ec031b)

Open in CodSpeed

@poljar poljar force-pushed the poljar/qr-login/msc4388 branch from e50a48d to 2379010 Compare February 16, 2026 08:58
@poljar poljar force-pushed the poljar/qr-login/msc4388 branch 2 times, most recently from fb95097 to 5849fcc Compare February 25, 2026 11:20
@poljar poljar force-pushed the poljar/qr-login/msc4388 branch 4 times, most recently from fc70d24 to 036dd95 Compare March 18, 2026 13:08
Comment thread crates/matrix-sdk/src/authentication/oauth/mod.rs Outdated
Comment thread crates/matrix-sdk/src/authentication/oauth/qrcode/messages.rs
} else {
QrAuthMessage::LoginProtocols(LoginProtocolsMessage::Msc4108 {
protocols: vec![LoginProtocolType::DeviceAuthorizationGrant],
homeserver: self.client.homeserver(),
Copy link
Copy Markdown
Member

@hughns hughns Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// n.b. this doesn't match the MSC which says that it is a server name not the base URL
// Should be something like self.client.user_id_server_name()

@poljar poljar force-pushed the poljar/qr-login/msc4388 branch from cb359ee to 3a6c47b Compare April 29, 2026 11:14
@poljar poljar force-pushed the poljar/qr-login/msc4388 branch from 4a17eb9 to 94061ac Compare April 29, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants