fix: KeyBuilder.buildKeyWithSharedDomain for EC keys#12
Merged
martinpaljak merged 5 commits intomartinpaljak:nextfrom Dec 1, 2025
Merged
Conversation
| * @see javacard.security.KeyBuilder | ||
| */ | ||
| public ECPrivateKeySharedImpl(byte keyType, short keySize, byte memoryType, ECKeyImpl sharedDomain) { | ||
| super(keyType, keySize, memoryType, sharedDomain); |
Owner
There was a problem hiding this comment.
There was something that made me question the current implementation hierarchy and associated assumptions of BC dependency, but can't find the relevant notes right now.
Author
There was a problem hiding this comment.
For me it was ECKeyImpl at first, that made me question why there are a, b, g, r, fp, that should not exist for shared version of the key.
But it's simple: ECKey is an interface, so ECKeySharedImpl does not have to store any domain parameters inside.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11