Skip to content

Universal jQuery module loader#17

Open
ghost wants to merge 3 commits intomarrio-h:masterfrom
mohammed-larbi-jebari:master
Open

Universal jQuery module loader#17
ghost wants to merge 3 commits intomarrio-h:masterfrom
mohammed-larbi-jebari:master

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Oct 7, 2019

#16 (comment)

Hi Marrio,

Thank you for this great js plugin,we planned to use it in our project and it will be awesome if you convert your plugin to an Jquery Plugin.
check this Example to create an Universal JS module loader:
https://github.com/umdjs/umd/blob/master/templates/jqueryPlugin.js
Regards,

@ghost ghost mentioned this pull request Oct 7, 2019
@ghost
Copy link
Copy Markdown
Author

ghost commented Oct 7, 2019

Could you please create a new tag 1.3.2 before accepted this pull request and a new tag 1.3.3 after accepted this pull request.

@marrio-h
Copy link
Copy Markdown
Owner

marrio-h commented Sep 9, 2022

Hey mate. Sorry for not getting back to you (at all or anyone else for that matter) kinda forgot about this, but originally I want this project to be pure vanilla JS so that anyone can pull and use it out-of-the-box :)

If you want - feel free to fork the project and make a jQuery version :)

But, if we made a "jQuery" branch - is there any drawbacks? Apart form maintaining two "master" branches. WHats your thoughts? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant