Fix bmp alloc dos#64
Open
Korolikc wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a denial-of-service issue in
bmp_img_alloc()where crafted BMP headerscan trigger excessive memory allocations leading to OOM/abort.
Root cause
bmp_img_alloc()performed allocations based on untrustedbiWidth/biHeightwithout validating ranges or guarding against overflow.
Changes
bmp_img_alloc()to returnenum bmp_errorand validate dimensions:INT_MINheight (abs overflow case)SIZE_MAXoverflow checks before allocationbmp_img_read()now checks allocation result and exits gracefully on failure.abs()usage on unsigned indices.Verification
A minimized PoC BMP file previously triggered ASan OOM in
bmp_img_alloc().After this patch, the same PoC is rejected and the program exits normally
(no crash / abort).