Skip to content

conv1d#506

Open
malmaud wants to merge 2 commits intomasterfrom
conv1d
Open

conv1d#506
malmaud wants to merge 2 commits intomasterfrom
conv1d

Conversation

@malmaud
Copy link
Copy Markdown
Owner

@malmaud malmaud commented May 17, 2019

Rebased version of #480

@malmaud malmaud requested a review from oxinabox as a code owner May 17, 2019 18:03
@malmaud malmaud mentioned this pull request May 17, 2019
AutoHashEquals 0.1.0
MLDatasets 0.3.0
SpecialFunctions 0.7.0
Optim 0.17.0
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can now delete the REQUIRE file



using Distributed
using Optim
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this in This PR?

@codecov
Copy link
Copy Markdown

codecov bot commented May 17, 2019

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.20%. Comparing base (32dd975) to head (485d3ad).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
src/ops/nn.jl 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #506      +/-   ##
==========================================
- Coverage   54.70%   53.20%   -1.50%     
==========================================
  Files          86       83       -3     
  Lines        2702     2654      -48     
==========================================
- Hits         1478     1412      -66     
- Misses       1224     1242      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants