fix: unrobust time relevant tostring functions.#24
Merged
johannessen merged 2 commits intomajensen:mainfrom Aug 2, 2025
Merged
fix: unrobust time relevant tostring functions.#24johannessen merged 2 commits intomajensen:mainfrom
johannessen merged 2 commits intomajensen:mainfrom
Conversation
`localtime` and `gmtime` are multithread unsafe functions. Use them in multithread scenes will result in unpredictable consequences. Use `localtime_r` and `gmtime_r` instead.
The previous implementation for formatting timezone offsets incorrectly assumed all offsets are full hours. It calculated the hour component via integer division (`offset / 3600`) and hardcoded "00" for the minutes. This resulted in incorrect timestamps for timezones with 30 or 45-minute offsets, such as India Standard Time (IST, +05:30) being formatted as "+0500" instead of the correct "+0530".
npc1054657282
force-pushed
the
fix/unrobust-datetime-tostring
branch
from
8a37235 to
d230ddd
Compare
johannessen
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
localtimeandgmtimeused in time relevant to string functions. Use them in multithread scenes will result in unpredictable consequences. Uselocaltime_randgmtime_rinstead.