feat:patch bolt "utc" support in Bolt 4.4#23
Merged
johannessen merged 4 commits intomajensen:mainfrom Aug 6, 2025
Merged
Conversation
Add minor protocol version to debug log message.
The minor version is incorrectly masked with octal `0700`. It get the false minor version(always zero). The true mask is to use hexadecimal `0x0700`.
To solve the protocol violation issue. The neo4j-omni always serializes `DateTime` to the modern structure defined in Bolt 5.0. The Bolt 4.x version cannot unpack it. However, the Bolt 4.4 version may unpack the Bolt 5.0 `DateTime` with a "utc" `patch-bolt`. I just try to use this to solve the problem at least in Bolt 4.4.
6 tasks
johannessen
requested changes
Aug 2, 2025
Collaborator
There was a problem hiding this comment.
In the default configuration, Bolt 4.0 is still preferred, so #22 will continue to be a problem.
I’d say this patch should also change the default supported versions from 4.0 to 4.4 (in client_config.c).
1207dc9 to
86041a9
Compare
BREAKING CHANGE: Dropped default support for version 4.0. Now default 4.x version is 4.4.
86041a9 to
cca4e1b
Compare
johannessen
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
patch boltin bolt version 4.4. Resolves Protocol Violation: Client sends Bolt 5.0 DateTime format when Bolt 4.x is negotiated #22