feat: introduces builder images#590
Open
bartoszmajsak wants to merge 2 commits intomasterfrom
Open
Conversation
bartoszmajsak
added
kind/enhancement
Contributor
Author
|
/test openshift |
Contributor
Author
|
/retest |
3 similar comments
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Collaborator
|
@bartoszmajsak: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
bartoszmajsak
force-pushed
the
master
branch
8 times, most recently
from
6299d95 to
6c6bacd
Compare
aslakknutsen
force-pushed
the
master
branch
from
5e555b3 to
024dbac
Compare
aslakknutsen
requested changes
Sep 20, 2021
| sudo circleci-install golang 1.14.7 | ||
| docker: | ||
| - image: &golang-img cimg/go:1.15.5 | ||
| - image: &golang-img cimg/go:1.14.7 |
| @@ -1,3 +1,19 @@ | |||
| FROM registry.access.redhat.com/ubi8/go-toolset:1.14.7 AS builder | |||
Member
There was a problem hiding this comment.
Don't we require 1.16.x now due to the fs thinggy?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Leverages docker builder images/ multistage build to build controller and test service.
Changes proposed in this pull request:
Dockerfiles.dockerignoreMakefileFixes #588