Skip to content

Remove upper bound for python dependency#239

Open
nat-n wants to merge 1 commit intom-burst:masterfrom
nat-n:master
Open

Remove upper bound for python dependency#239
nat-n wants to merge 1 commit intom-burst:masterfrom
nat-n:master

Conversation

@nat-n
Copy link
Copy Markdown

@nat-n nat-n commented May 2, 2023

Currently this project declares that it is not compatible with python >=4.0, this sounds reasonable in that
"python 4.0" is kind of an abstract concept, but has the unfortunate side effect that any projects that do not make the same declaration cannot depend on flake8-broken-line, or any other project that depends on it!

This post elaborates better than I can on why it is a better practice to only set a lower bound for python compatibility in almost all cases: https://iscinumpy.dev/post/bound-version-constraints/

This change is required as a prerequisite of a similar change here, which in turn is required before I can upgrade rstcheck to a recent version here.

@codecov
Copy link
Copy Markdown

codecov bot commented May 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4c8ba08) 96.66% compared to head (04e9fd0) 96.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #239   +/-   ##
=======================================
  Coverage   96.66%   96.66%           
=======================================
  Files          13       13           
  Lines         599      599           
  Branches      129      129           
=======================================
  Hits          579      579           
  Misses          7        7           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant