Fix disk space check and transformers 4.35+ compatibility#267
Open
MuhammadEmmadSiddiqui wants to merge 1 commit intolyogavin:mainfrom
Open
Fix disk space check and transformers 4.35+ compatibility#267MuhammadEmmadSiddiqui wants to merge 1 commit intolyogavin:mainfrom
MuhammadEmmadSiddiqui wants to merge 1 commit intolyogavin:mainfrom
Conversation
- Fix check_space() to detect existing split files when layer_shards_saving_path=None - Add rotary embeddings compatibility for transformers 4.35+ - Filter out obsolete rotary_emb parameters from saved state - Dynamically compute position_embeddings required by newer transformers Tested with Python 3.13, transformers 4.35.0, and 70B Llama models
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with Python 3.13, transformers 4.35.0, and 70B Llama models