Skip to content

fix: communication diagram edge label overlapping with vertical edge #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tamang29 wants to merge 4 commits into
base: main
Choose a base branch
from
+14 −12
Open

fix: communication diagram edge label overlapping with vertical edge #645

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42343a6
fix: communication diagram edge label overlapping with vertical edge
tamang29 Apr 26, 2026
8699bfb
Merge branch 'main' into fix/communication-diagram-edge-label
tamang29 Apr 27, 2026
e380986
Merge branch 'main' into fix/communication-diagram-edge-label
tamang29 Apr 27, 2026
16209de
Merge branch 'main' into fix/communication-diagram-edge-label
tamang29 Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions library/lib/hooks/useMessagePositioning.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,9 @@ export const useMessagePositioning = (
const forwardArrowRotation = calculateRotation(targetArrowDirection)
const backwardArrowRotation = calculateRotation(sourceArrowDirection)

const baseOffset = 15
const labelOffset = 12
const BASE_OFFSET_X = -90
const BASE_OFFSET_Y = 20
const LABEL_OFFSET = 18

// Position labels and arrows based on actual middle segment orientation
let forwardArrowBoxPosition: { x: number; y: number }
Expand All @@ -80,19 +81,20 @@ export const useMessagePositioning = (
let backwardLabelBoxPosition: { x: number; y: number }

if (isHorizontalEdge) {
// Horizontal middle segment: messages above and below
forwardArrowBoxPosition = { x: 0, y: -baseOffset }
forwardLabelBoxPosition = { x: labelOffset, y: -baseOffset }
// Horizontal edge: labels above and below, arrow + label go left→right
forwardArrowBoxPosition = { x: 0, y: -BASE_OFFSET_Y }
forwardLabelBoxPosition = { x: LABEL_OFFSET, y: -BASE_OFFSET_Y }

backwardArrowBoxPosition = { x: 0, y: baseOffset }
backwardLabelBoxPosition = { x: labelOffset, y: baseOffset }
backwardArrowBoxPosition = { x: 0, y: BASE_OFFSET_Y }
backwardLabelBoxPosition = { x: LABEL_OFFSET, y: BASE_OFFSET_Y }
} else {
// Vertical middle segment: messages left and right
forwardArrowBoxPosition = { x: baseOffset, y: 0 }
forwardLabelBoxPosition = { x: baseOffset + labelOffset, y: 0 }
// Vertical edge: forward label on the RIGHT side
forwardArrowBoxPosition = { x: BASE_OFFSET_X, y: 0 }
forwardLabelBoxPosition = { x: BASE_OFFSET_X + LABEL_OFFSET, y: 0 }

backwardArrowBoxPosition = { x: -baseOffset, y: 0 }
backwardLabelBoxPosition = { x: -baseOffset - labelOffset, y: 0 }
// Vertical edge: backward label on the LEFT side
backwardArrowBoxPosition = { x: -BASE_OFFSET_X, y: 0 }
backwardLabelBoxPosition = { x: -(BASE_OFFSET_X + LABEL_OFFSET), y: 0 }
}

return {
Expand Down
Loading