change to new mirror, dry kafka version, better curl flags#198
Open
jsvd wants to merge 3 commits intologstash-plugins:mainfrom
Open
change to new mirror, dry kafka version, better curl flags#198jsvd wants to merge 3 commits intologstash-plugins:mainfrom
jsvd wants to merge 3 commits intologstash-plugins:mainfrom
Conversation
04b4ef1 to
7333ff8
Compare
7333ff8 to
1d612ed
Compare
Member
Author
|
@kaisecheng since you're deep into the kafka plugin code, maybe you can review this? thanks |
Contributor
|
@jsvd Once the conflicts are resolved, I can approve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three concerns are mixed in this PR, I can split them into separate PRs if the reviewer so wishes: