fix schema registry proxy handling#170
Draft
jsvd wants to merge 2 commits intologstash-plugins:mainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change
schema_registry_proxysetting from uri to string to move URI validation further down so that "" is an acceptable value. accepting "" is useful when doing something like:But depending on environment that env var may be empty. This removes the need for templating.
To support this we need to validate the URI a bit later.
Also this PR removes uri handling of https and basic auth for the proxy url given that the schema registry itself doesn't support it either (see confluentinc/schema-registry#2137)
fixes #144