Remove SQLite dependency from lnt checkformat#201
Merged
Conversation
Before this patch, `lnt checkformat` would create a temporary instance and try importing the report into that database. This was great since it checked not only the format of the report, but also whether the report can actually be ingested into an instance. However, the downside was additional complexity and a hardcoded reliance on SQlite, which we're moving away from. This patch greatly simplifies `checkformat` but slightly reduces its level of checking. Instead, `checkformat` ensures that the report has valid syntax but doesn't try to actually ingest it into an instance. As a side effect, this means that `checkformat` now also works with reports that don't only target the `nts` test suite.
Member
Author
|
For backwards compatibility, I checked and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this patch,
lnt checkformatwould create a temporary instance and try importing the report into that database. This was great since it checked not only the format of the report, but also whether the report can actually be ingested into an instance.However, the downside was additional complexity and a hardcoded reliance on SQlite, which we're moving away from.
This patch greatly simplifies
checkformatbut slightly reduces its level of checking. Instead,checkformatensures that the report has valid syntax but doesn't try to actually ingest it into an instance.As a side effect, this means that
checkformatnow also works with reports that don't only target thentstest suite.