This repository was archived by the owner on Feb 21, 2026. It is now read-only.
[CIR] Relax CastOp verifier for scalar bitcasts#2086
Merged
bcardosolopes merged 2 commits intollvm:mainfrom Jan 23, 2026
Merged
[CIR] Relax CastOp verifier for scalar bitcasts#2086bcardosolopes merged 2 commits intollvm:mainfrom
bcardosolopes merged 2 commits intollvm:mainfrom
Conversation
mahmood82
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
bcardosolopes
suggested changes
Jan 12, 2026
Relax CastOp verification to allow scalar-to-scalar bitcasts when the source and result types have identical DataLayout sizes. This enables builtin as_type-style conversions (e.g. float <-> int) to be represented as cir.cast bitcast operations without being rejected by the verifier.
mahmood82
force-pushed
the
users/mahmood/scalar_to_scalar_bitcast
branch
from
5aef593 to
4234363
Compare
bcardosolopes
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relax CastOp verification to allow scalar-to-scalar bitcasts when the source and result types have identical DataLayout sizes. This enables builtin as_type-style conversions (e.g. float <-> int) to be represented as cir.cast bitcast operations without being rejected by the verifier.