Open
Conversation
Contributor
Author
|
I've also added an optional argument that lets you specify the type of waif you are looking for: |
StraylightRunMOO
added a commit
to StraylightRunMOO/toaststunt
that referenced
this pull request
Apr 5, 2023
MAX_BASE_FUNC overflow causes function 256 (counting from 0) to overflow, creating a call to function 0 (run_gc)
Checking out from master, the function is `char_list()`. Checking `;function_info()[257][1]` should tell you the affected builtin if you're running a modified build.
Before:
```
;char_list("bob")
#-1:Input to EVAL (this == #-1), line 3: Incorrect number of arguments (expected 0; got 1)
... called from built-in function eval()
... called from lisdude#58:eval_cmd_string, line 19
... called from lisdude#58:eval*-d, line 13
(End of traceback)
```
After:
```
;char_list("bob")
=> {"b", "o", "b"}
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a builtin that returns all waifs called "waifs()"
It is garbage collector safe and doesn't maintain a reference to waifs.
For example:
When the game recycles the WAIF it also removes it from the cache of all waif references. This is much faster than the in-moo implementation of searching every property on every object in the game and is much safer.