Allow configuring a Maven Central mirror via system property by yzfeng2020 · Pull Request #6712 · line/armeria

yzfeng2020 · 2026-04-07T23:14:11Z

Motivation

Due to recent supply chain security concerns, many organizations block direct access to Maven Central and route artifact downloads through an internal mirror or proxy for auditing and control.

Armeria's build currently hardcodes mavenCentral() and gradlePluginPortal() across multiple Gradle scripts, including buildscript {} blocks in apply from: scripts that cannot be overridden via Gradle init scripts. This makes it impossible to build Armeria in restricted network environments without modifying project files directly.

Modifications

Introduced a mavenCentralMirror Java system property recognized by all repository declarations.
When set, the mirror URL replaces mavenCentral() (and supplements it where appropriate).
When unset, behavior is identical to the current build — fully backward compatible.
Added a pluginManagement block to settings.gradle to cover settings-level plugin resolution.

Usage

Add to ~/.gradle/gradle.properties:

systemProp.mavenCentralMirror=https://your-mirror.example.com

Or pass via the CLI:

./gradlew build -DmavenCentralMirror=https://your-mirror.example.com

Why `System.getProperty()` instead of Gradle project properties?

buildscript {} blocks in apply from: scripts use separate ScriptHandler objects that cannot access project-level extensions or properties. System.getProperty() is the only mechanism available in all evaluation contexts: settings.gradle, buildSrc, and applied scripts' buildscript {} blocks.

Result

mavenCentralMirror is set: all Maven Central traffic is routed through the specified mirror.
mavenCentralMirror is not set: no behavior change.

Add support for a `mavenCentralMirror` system property that allows users behind corporate proxies or firewalls to redirect all Maven Central traffic through a mirror repository. Users can configure this in `~/.gradle/gradle.properties`: systemProp.mavenCentralMirror=https://your-mirror.example.com When unset, behavior is identical to today (uses mavenCentral()). Co-authored-by: Isaac

github-actions · 2026-04-07T23:30:28Z

🔍 Build Scan® (commit: `3ec6509`)

Job name	Status	Build Scan®
build-ubicloud-standard-16-jdk-8	✅	https://ge.armeria.dev/s/cnw74aecqmd42
build-ubicloud-standard-16-jdk-25	✅	https://ge.armeria.dev/s/5kzehva2xbewe
build-ubicloud-standard-16-jdk-21-snapshot-blockhound	✅	https://ge.armeria.dev/s/v5uf4czu4752c
build-ubicloud-standard-16-jdk-17-min-java-17-coverage	✅	https://ge.armeria.dev/s/amtf2jwjdwwm4
build-ubicloud-standard-16-jdk-17-min-java-11	✅	https://ge.armeria.dev/s/luoqjw53ijgtw
build-ubicloud-standard-16-jdk-17-leak	✅	https://ge.armeria.dev/s/esktwpjhwx4km
build-ubicloud-standard-16-jdk-11	✅	https://ge.armeria.dev/s/mgs2s3itqlrg2
build-macos-latest-jdk-25	❌ (failure)	https://ge.armeria.dev/s/6dyedlynoc6pm

codecov · 2026-04-07T23:47:22Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.99%. Comparing base (8150425) to head (3ec6509).
⚠️ Report is 409 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #6712      +/-   ##
============================================
- Coverage     74.46%   73.99%   -0.47%     
- Complexity    22234    24121    +1887     
============================================
  Files          1963     2176     +213     
  Lines         82437    90501    +8064     
  Branches      10764    11859    +1095     
============================================
+ Hits          61385    66970    +5585     
- Misses        15918    17915    +1997     
- Partials       5134     5616     +482

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coderabbitai · 2026-04-08T00:28:59Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a5268001-0413-468f-89a6-9adaa1c1a70d

📥 Commits

Reviewing files that changed from the base of the PR and between 339b5dd and 3ec6509.

📒 Files selected for processing (8)

build.gradle
buildSrc/build.gradle
gradle/scripts/lib/common-dependencies.gradle
gradle/scripts/lib/java-rpc-proto.gradle
gradle/scripts/lib/java-shade.gradle
gradle/scripts/version-catalog.gradle
settings.gradle
site-new/build.gradle

📝 Walkthrough

Walkthrough

Gradle build configuration files are updated to conditionally resolve Maven artifacts from a custom mirror URL via the mavenCentralMirror JVM system property, defaulting to standard repositories when the property is unset. The changes apply this pattern consistently across root, subproject, and plugin repository configurations.

Changes

Cohort / File(s)	Summary
Root and Plugin Build Configuration `build.gradle`, `buildSrc/build.gradle`, `settings.gradle`	Added conditional Maven repository resolution: when `mavenCentralMirror` system property is set, routes to custom mirror URL; otherwise defaults to `mavenCentral()` or `gradlePluginPortal()`. In `settings.gradle`, introduced new `pluginManagement` block for plugin repository management.
Gradle Script Libraries `gradle/scripts/lib/common-dependencies.gradle`, `gradle/scripts/lib/java-rpc-proto.gradle`, `gradle/scripts/lib/java-shade.gradle`, `gradle/scripts/version-catalog.gradle`	Consistently applied conditional Maven repository logic to buildscript repository configurations across all library scripts, replacing or supplementing static `mavenCentral()` with property-driven mirror resolution.
Site Subproject Build `site-new/build.gradle`	Updated buildscript repository configuration to use conditional `mavenCentralMirror` property with fallback to default `mavenCentral()`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A mirror for Maven, we've configured with care,
When mavenCentralMirror floats through the air,
The builds find their path to packages so true,
Or default to the standard when properties are through,
Flexibility blooms in our Gradle scripts new! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and specifically describes the main change: adding support for configuring a Maven Central mirror via system property.
Description check	✅ Passed	The description is comprehensive and directly related to the changeset, explaining motivation, modifications, usage, and implementation rationale.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

jrhee17

Overall looks good, left some questions

jrhee17 · 2026-04-08T01:16:21Z

buildSrc/build.gradle

+	} else {
+		mavenCentral()
+	}
 	gradlePluginPortal()


Question) Just to be sure, the target is only mavenCentral and not other repositories - is my understanding correct?

jrhee17 · 2026-04-08T01:23:09Z

gradle/scripts/lib/common-dependencies.gradle

 buildscript {
    repositories {
-        mavenCentral()
+        def mavenCentralMirror = System.getProperty('mavenCentralMirror')


Note: This is unfortunate, we should move on to using conventions plugins instead so that we don't have to redeclare this for every buildscript closure

jrhee17 · 2026-04-08T01:25:02Z

settings.gradle

+// ~/.gradle/gradle.properties to redirect all Maven Central requests to a mirror.
+pluginManagement {
+    repositories {
+        def mavenCentralMirror = System.getProperty('mavenCentralMirror')


Question) Is it possible to use gradle properties (providers.gradleProperty or project.findProperty) instead of system properties? (in case we want finer control over overwriting per project, etc. in the future)

ikhoon · 2026-04-08T05:58:34Z

Would we follow the style used for OSS Sonatype URL?

armeria/gradle.properties

Lines 17 to 18 in 339b5dd

    
           publishUrlForRelease=https://ossrh-staging-api.central.sonatype.com/service/local/staging/deploy/maven2/ 
        
           publishUrlForSnapshot=https://central.sonatype.com/repository/maven-snapshots/

minwoox

Please, address @jrhee17's comments. Thanks!

yzfeng2020 requested review from ikhoon, jrhee17, minwoox and trustin as code owners April 7, 2026 23:14

yzfeng2020 force-pushed the feature/configurable-maven-central-mirror branch from 60952ae to 3ec6509 Compare April 7, 2026 23:24

jrhee17 reviewed Apr 8, 2026

View reviewed changes

ikhoon added the miscellaneous label Apr 8, 2026

ikhoon added this to the 1.39.0 milestone Apr 8, 2026

minwoox approved these changes Apr 8, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow configuring a Maven Central mirror via system property#6712

Allow configuring a Maven Central mirror via system property#6712
yzfeng2020 wants to merge 1 commit intoline:mainfrom
yzfeng2020:feature/configurable-maven-central-mirror

yzfeng2020 commented Apr 7, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 7, 2026 •

edited

Loading

Uh oh!

codecov bot commented Apr 7, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Apr 8, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

jrhee17 left a comment

Uh oh!

jrhee17 Apr 8, 2026

Uh oh!

jrhee17 Apr 8, 2026

Uh oh!

jrhee17 Apr 8, 2026

Uh oh!

ikhoon commented Apr 8, 2026

Uh oh!

minwoox left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

yzfeng2020 commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Modifications

Usage

Why System.getProperty() instead of Gradle project properties?

Result

Uh oh!

github-actions bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔍 Build Scan® (commit: 3ec6509)

Uh oh!

codecov bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

jrhee17 left a comment

Choose a reason for hiding this comment

Uh oh!

jrhee17 Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

jrhee17 Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

jrhee17 Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

ikhoon commented Apr 8, 2026

Uh oh!

minwoox left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yzfeng2020 commented Apr 7, 2026 •

edited

Loading

Why `System.getProperty()` instead of Gradle project properties?

github-actions bot commented Apr 7, 2026 •

edited

Loading

🔍 Build Scan® (commit: `3ec6509`)

codecov bot commented Apr 7, 2026 •

edited

Loading

coderabbitai bot commented Apr 8, 2026 •

edited

Loading