Conversation
|
Probably related to I won't be able to return to this until maybe 12 hours from now, so if other maintainers look before I do, please feel free to just push directly to my PR here. Otherwise, I'll try to fix this later. update (Apr 21): documented in #7238, workaround pushed here** |
|
Ok this is finally passing! I think it will resolve all of our current CI-blocking issues. |
| # TODO: remove 'type: ignore[attr-defined]' when https://github.com/apache/arrow/issues/49831 is resolved. | ||
| if pa_compute.all(pa_compute.equal(weight, 1)).as_py(): # type: ignore[attr-defined] |
There was a problem hiding this comment.
Just an fyi because of the TODO comment: I'm still planning on unifying our data frame intake processing via Narwhals at some point; this would alleviate the need for this.
There was a problem hiding this comment.
Thanks for the comment.
I'm a bit skeptical of a narwhals dependency in lightgbm. We have so little data frame manipulation here (mostly just read-only access to types, size, and the underlying data), I'm unsure that narwhals will bring enough simplification or other benefits to justify adding a dependency and all the burden that comes with that (including effectively losing control of our minimum pandas and pyarrow versions).
But I'm willing to be convinced! And anyway, we can continue that conversation on a draft PR or #6204
Another day, more broken CI 😅
Fixes #7238
Fixes #7235
Fixes #7208 (again)
See those issues for details.