Skip to content

[ci] [dask] test lightgbm.dask on macOS#6677

Merged
StrikerRUS merged 8 commits intomasterfrom
ci/mac-dask-tests
Mar 2, 2025
Merged

[ci] [dask] test lightgbm.dask on macOS#6677
StrikerRUS merged 8 commits intomasterfrom
ci/mac-dask-tests

Conversation

@jameslamb
Copy link
Copy Markdown
Member

Contributes to #3782

Enables the Dask tests on macOS, based on this comment form @neNasko1 : #6569 (comment)

Comment thread .vsts-ci.yml
displayName: 'Clean source directory'
# LGBM_SKIP_DASK_TESTS=true is set below only because running the tests under emulation is so slow...
# in theory, 'lightgbm.dask' should work without issue on aarch64 Linux systems.
# That could probably be removed as part of https://github.com/microsoft/LightGBM/issues/6788
Copy link
Copy Markdown
Member Author

@jameslamb jameslamb Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this LGBM_SKIP_DASK_TESTS machinery could be removed if #6843 is merged before this.

If this PR is merged first, then I'll remove that stuff in #6843

@jameslamb jameslamb changed the title WIP: [ci] [dask] test lightgbm.dask on macOS [ci] [dask] test lightgbm.dask on macOS Feb 28, 2025
@jameslamb
Copy link
Copy Markdown
Member Author

This is now working! I think it's ready for review.

@jameslamb jameslamb marked this pull request as ready for review February 28, 2025 05:54
Copy link
Copy Markdown
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great PR, thanks!
Very nice to see Dask working on macOS! 🎉

@StrikerRUS
Copy link
Copy Markdown
Collaborator

Just one question: why don't we test the latest Dask among the latest libraries?
https://github.com/microsoft/LightGBM/blob/master/.ci/test-python-latest.sh

@StrikerRUS StrikerRUS merged commit f7c641d into master Mar 2, 2025
@StrikerRUS StrikerRUS deleted the ci/mac-dask-tests branch March 2, 2025 15:08
@StrikerRUS
Copy link
Copy Markdown
Collaborator

Also, maybe it's better to use feature label for this PR to help users discover info about Dask support on macOS? I bet very few people read Maintenance section of Release Notes 😄

@jameslamb
Copy link
Copy Markdown
Member Author

Sure, we can switch this to feature. I was thinking maintenance because it is just adding testing (it was technically possible to use lightgbm.dask on macOS before), but I can understand how feature because this PR means this is now more fully "supported".

@jameslamb
Copy link
Copy Markdown
Member Author

Just one question: why don't we test the latest Dask among the latest libraries? https://github.com/microsoft/LightGBM/blob/master/.ci/test-python-latest.sh

I think I did not add it there when setting that up because there weren't nightly versions published of dask / distributed ... so lots of other CI jobs already were capturing testing LightGBM against the latest releases of dask / distributed.

I'd support trying something like this in those jobs if you'd like to try it:

python -m pip install 'git+https://github.com/dask/dask.git@main'

Although some things to note:

@jameslamb
Copy link
Copy Markdown
Member Author

oops sorry, I meant feature not featurevrequest, thank you for fixing that @StrikerRUS

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 5, 2026

This pull request has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants