Skip to content

fix: the rmsgpack_dom in rmsgpack_dom.c#19027

Open
orbisai0security wants to merge 1 commit into
libretro:masterfrom
orbisai0security:fix-rmsgpack-dom-string-len-overflow
Open

fix: the rmsgpack_dom in rmsgpack_dom.c#19027
orbisai0security wants to merge 1 commit into
libretro:masterfrom
orbisai0security:fix-rmsgpack-dom-string-len-overflow

Conversation

@orbisai0security
Copy link
Copy Markdown

Summary

Fix critical severity security issue in libretro-db/rmsgpack_dom.c.

Vulnerability

Field Value
ID V-001
Severity CRITICAL
Scanner multi_agent_ai
Rule V-001
File libretro-db/rmsgpack_dom.c:550
CWE CWE-120

Description: The rmsgpack_dom.c file performs memcpy operations using min_len derived from attacker-controlled msgpack data. If min_len is computed from a separately parsed (and potentially attacker-controlled) length value without validating it against the actual allocated destination buffer capacity, a heap buffer overflow occurs. This affects both binary buffer copies (line 553) and string buffer copies (line 562).

Changes

  • libretro-db/rmsgpack_dom.c

Verification

  • Build passes
  • Scanner re-scan confirms fix
  • LLM code review passed

Automated security fix by OrbisAI Security

Automated security fix generated by Orbis Security AI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant