Add underlay functionality to OGL1/2/3 and vulkan drivers#19000
Open
hunterk wants to merge 4 commits into
Open
Add underlay functionality to OGL1/2/3 and vulkan drivers#19000hunterk wants to merge 4 commits into
hunterk wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guidelines
C89_BUILD=1Description
A lot of people use overlays cosmetically for borders/bezels, and they currently have to include a transparent cutout to match the content exactly, which means separate overlays for integer and non-integer, and no freedom to change aspect ratios from, say, nominal 4:3 to 8:7 (1:1 PAR for S/NES) without introducing either black borders or cutting off game content.
This PR adds a "overlayX_background_fill" flag to the overlay subsystem to allow users to put an overlay behind the game image instead of on top of it, so the overlay gets obscured when the game image changes size instead of the other way around.
I haven't yet added this to any of the D3D drivers because I don't have any good way of testing them, and they're currently experiencing a lot of churn.
Related Issues
closes #9536 and closes #15138
Related Pull Requests
none
Reviewers
@sonninnos and @LibretroAdmin (in case you'd like to add support to the D3D drivers)