Prevent Rx/Tx clash by preventing receive_packet from reading while s…#8
Open
jsonpoindexter wants to merge 1 commit into
Open
Prevent Rx/Tx clash by preventing receive_packet from reading while s…#8jsonpoindexter wants to merge 1 commit into
jsonpoindexter wants to merge 1 commit into
Conversation
…elf._lock is true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…elf._lock is true
While using the uPyLoRaWAN with an asynchronous web server, MicroWebSrv2, I noticed that my Tx data was being corrupted which I believe is due to
received_packetresetting the FiFo address (?). To preventreceived_packetfrom executing during a Tx I added a check to see if a lock has been set.Example web server / lora code
Full code: https://github.com/jsonpoindexter/ulora-ttgo-chat/blob/98c125402dc09cda549f147c66f7c66e4dac1646/main.py
When no lock is implemented in
received_packet()the payload would be corrupted when receiving it on another device:When the transmitting device had
if lora.received_packet():removed/commented out the payload would be received intact.