Skip to content

👷 add Minimum Dart CI workflow#709

Merged
techouse merged 3 commits intodevelopfrom
chore/minimum-dart
May 3, 2026
Merged

👷 add Minimum Dart CI workflow#709
techouse merged 3 commits intodevelopfrom
chore/minimum-dart

Conversation

@techouse
Copy link
Copy Markdown
Collaborator

@techouse techouse commented May 3, 2026

This pull request introduces a new GitHub Actions workflow for testing packages against their minimum supported Dart SDK versions, and also updates permissions in existing workflow files for improved security.

CI/CD Improvements:

  • Added a new workflow file .github/workflows/minimum_dart.yml to automatically test each package (chopper, chopper_built_value, chopper_generator) against its minimum Dart SDK version, across both VM and Chrome platforms. This ensures ongoing compatibility with the lowest supported Dart versions.

Security Enhancements:

  • Updated the permissions in .github/workflows/publish.yml and .github/workflows/publish_dry_run.yml from read-all to a more restrictive contents: read, following GitHub's best practices for least privilege. [1] [2]

@codecov
Copy link
Copy Markdown

codecov Bot commented May 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.05%. Comparing base (8f1c7f9) to head (2d3f9d7).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #709   +/-   ##
========================================
  Coverage    99.05%   99.05%           
========================================
  Files           23       23           
  Lines          530      530           
========================================
  Hits           525      525           
  Misses           5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@techouse techouse requested a review from Copilot May 3, 2026 10:30
@techouse techouse marked this pull request as ready for review May 3, 2026 10:30
@techouse techouse added this to the 8.5.2 milestone May 3, 2026
@techouse techouse added the ci Continuous Integration label May 3, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new GitHub Actions workflow to continuously validate that each package in the repo still works on its minimum supported Dart SDK version, and tightens default workflow token permissions for publish workflows.

Changes:

  • Added Minimum Dart CI workflow to run analyze/tests against each package’s minimum Dart SDK (VM and Chrome where configured).
  • Reduced default GITHUB_TOKEN permissions in publish workflows from read-all to contents: read.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/minimum_dart.yml New CI workflow to derive each package’s minimum Dart SDK from pubspec.yaml and run tests/analyze accordingly.
.github/workflows/publish.yml Restricts default workflow token permissions to least-privilege (contents: read).
.github/workflows/publish_dry_run.yml Restricts default workflow token permissions to least-privilege (contents: read).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/minimum_dart.yml
@techouse
Copy link
Copy Markdown
Collaborator Author

techouse commented May 3, 2026

Codecov tripping because of -0.06% 🤣

@JEuler sadly I can't tighten the permissions in .github/workflows/dart.yml because it's generated by mono_repo and hand-editing it makes

mono_repo generate --validate

fail.

@techouse techouse merged commit b588016 into develop May 3, 2026
16 checks passed
@techouse techouse deleted the chore/minimum-dart branch May 3, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants