Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #709 +/- ##
========================================
Coverage 99.05% 99.05%
========================================
Files 23 23
Lines 530 530
========================================
Hits 525 525
Misses 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a new GitHub Actions workflow to continuously validate that each package in the repo still works on its minimum supported Dart SDK version, and tightens default workflow token permissions for publish workflows.
Changes:
- Added
Minimum Dart CIworkflow to run analyze/tests against each package’s minimum Dart SDK (VM and Chrome where configured). - Reduced default
GITHUB_TOKENpermissions in publish workflows fromread-alltocontents: read.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/minimum_dart.yml | New CI workflow to derive each package’s minimum Dart SDK from pubspec.yaml and run tests/analyze accordingly. |
| .github/workflows/publish.yml | Restricts default workflow token permissions to least-privilege (contents: read). |
| .github/workflows/publish_dry_run.yml | Restricts default workflow token permissions to least-privilege (contents: read). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Codecov tripping because of @JEuler sadly I can't tighten the permissions in mono_repo generate --validatefail. |
This pull request introduces a new GitHub Actions workflow for testing packages against their minimum supported Dart SDK versions, and also updates permissions in existing workflow files for improved security.
CI/CD Improvements:
.github/workflows/minimum_dart.ymlto automatically test each package (chopper,chopper_built_value,chopper_generator) against its minimum Dart SDK version, across both VM and Chrome platforms. This ensures ongoing compatibility with the lowest supported Dart versions.Security Enhancements:
permissionsin.github/workflows/publish.ymland.github/workflows/publish_dry_run.ymlfromread-allto a more restrictivecontents: read, following GitHub's best practices for least privilege. [1] [2]