Load Nagios::CheckLogfiles::Search::Eventlog only if we are on Windows.#77
Open
hpreusse wants to merge 2 commits intolausser:masterfrom
Open
Load Nagios::CheckLogfiles::Search::Eventlog only if we are on Windows.#77hpreusse wants to merge 2 commits intolausser:masterfrom
hpreusse wants to merge 2 commits intolausser:masterfrom
Conversation
Author
|
This PR should addess parts of #73 |
|
Thanks for submitting the PR. Actually, you should use 'require' rather than 'use', so Nagios::CheckLogfiles::Search::Eventlog isn't used at compile time, only runtime. |
Author
|
@xavierba. I'm not a programmer at all, I just moved some code around. I've changed the fork and hence updated the PR. Thanks for the hint! |
Owner
|
I am aware of your comments here and i will have a look later. I'm just too busy in the moment... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.