fix(FR-2988): clarify revision-apply confirmation popup#7620
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
yomybaby
changed the title
yomybaby
added a commit
that referenced
this pull request
May 27, 2026
yomybaby
added a commit
that referenced
this pull request
May 27, 2026
Make the deployment revision-apply popconfirm self-explanatory. Previously the title was 'Apply' and the description showed only '#<revisionNumber>', which was easy to misread as a label rather than a confirmation prompt. - Add new i18n key 'deployment.ApplyRevision' for the popconfirm title. - Repurpose existing (previously unused) 'deployment.ApplyConfirm' as the description, shortened to 'Apply selected revision #N?'. - Apply the new copy to both popconfirm sites in DeploymentRevisionHistoryTab: the row action button and the detail drawer footer. - Propagate translations to all 21 locales. Also fixes a pre-existing test breakage caused by FR-2987: the mock at react/__test__/buiLanguage.mock.js was missing the new 'buiTranslations' export, which broke every test transitively importing DefaultProviders with 'TypeError: Cannot convert undefined or null to object' at the Object.entries(buiTranslations).forEach(...) call.
yomybaby
force-pushed
the
fr-2988-clarify-revision-apply-popconfirm
branch
from
2daac8a to
7881e91
Compare
Contributor
Coverage Report for react-coverage (./react)
File Coverage
|
||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7619 (FR-2988)
Summary
Clarify the confirmation popup that appears when applying a revision in the Deployment Revision History. Previously the popconfirm title was
Applyand the description was just#<revisionNumber>, which was easy to misread as a label rather than a confirmation prompt — a Frontend channel discussion flagged it as ambiguous.Changes
react/src/components/DeploymentRevisionHistoryTab.tsx— both popconfirm sites (row action + drawer footer) now use clearer copy.resources/i18n/*.json(21 locales)deployment.ApplyRevision→Apply revision(used as popconfirm title)deployment.ApplyConfirm→Apply selected revision #{{revisionNumber}}?(was previously unused; repurposed as the description)Before / After
ApplyApply revision/리비전 적용#3Apply selected revision #3?/선택하신 리비전 #3을(를) 적용하시겠습니까?Notes
antdPopconfirm— applying a revision is reversible (a different revision can be applied later), so the destructive-confirmation typed-modal rule does not apply.Test plan
{{revisionNumber}}placeholder filled in🤖 Generated with Claude Code