e2e(FR-2982): assert inviter email is shown in folder invitation modal#7610
Open
agatha197 wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
Extends an existing E2E helper to optionally assert the inviter's email appears in the folder invitation modal, then enables the assertion in the existing vfolder share test. This closes a coverage gap around the modal's "From" field, which currently has no unit, Storybook, or E2E verification.
Changes:
- Add optional
inviterEmailparameter toacceptAllInvitationAndVerifySpecificFolderand assert the modal contains it when provided. - Pass
userInfo.user.emailat the existing call site invfolder-crud.spec.tsso the assertion runs in CI.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| e2e/utils/test-util.ts | Adds optional inviterEmail argument and a toContainText assertion on the invitation modal. |
| e2e/vfolder/vfolder-crud.spec.ts | Passes inviter email (userInfo.user.email) to the helper to enable the new check. |
Contributor
Coverage Report for react-coverage (./react)
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
agatha197
force-pushed
the
e2e/FR-2982-assert-inviter-email-in-invitation-modal
branch
from
c89cb25 to
cbe1693
Compare
agatha197
changed the base branch from
graphite-base/7610
to
fix/FR-2979-shared-folder-invite-sender
5 tasks
agatha197
changed the base branch from
fix/FR-2979-shared-folder-invite-sender
to
graphite-base/7610
…rtion Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Fix `.nth(1)` → `.first()` for the Create Folder button in both `createVFolderAndVerify` (test-util.ts) and the two `beforeEach` blocks in vfolder-crud.spec.ts after FR-2691 removed the top action card. - Fix `restoreVFolderAndVerify` to wait for the Restore button to reach DELETE_PENDING state and confirm the Popconfirm that gates the action. - Remove brittle `/deleted forever/i` notification assertion from `deleteForeverAndVerifyFromTrash`; rely on row-gone check instead. - Make inviter-email assertion in `acceptAllInvitationAndVerifySpecificFolder` conditional on the backend actually returning `inviter_user_email` (some RC builds pass the version check but omit the field). - Increase `test.setTimeout` for VFolder Sharing and lifecycle tests from 90 s to 180 s. - Wrap host-app children in `I18nextProvider(i18n)` inside `DefaultProviders.tsx` and `LoginView.tsx` to prevent BUI's `BAIConfigProvider`→`I18nextProvider` from leaking into the host app's `useTranslation()` calls when pnpm deduplicates `react-i18next`. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
agatha197
force-pushed
the
e2e/FR-2982-assert-inviter-email-in-invitation-modal
branch
from
cbe1693 to
654d33d
Compare
agatha197
force-pushed
the
graphite-base/7610
branch
from
147f8b1 to
25baf00
Compare
agatha197
changed the base branch from
graphite-base/7610
to
fix/FR-2979-shared-folder-invite-sender
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7608 (FR-2982)
Summary
acceptAllInvitationAndVerifySpecificFolder(ine2e/utils/test-util.ts) with an optionalinviterEmailparameter.FolderInvitationResponseModalcontains that email before the Accept loop. This catches regressions in the modal's "From" field — i.e. brokenitem.inviter_user_emailplumbing or a brokeninvitation-inviter-emailcapability check.userInfo.user.email(the inviter set up byloginAsUserinbeforeEach) at the single existing call site ine2e/vfolder/vfolder-crud.spec.ts("User can share vFolder"), so the assertion runs in CI.Why
Test plan
vfolder/vfolder-crud.spec.ts"User can share vFolder" run passes with the new assertion enabled.invitation-inviter-emailcapability, the assertion confirmsuser@lablup.comis rendered inside the modal.item.inviter, a non-email value); intentional — this is the regression we want to surface.