Skip to content

chore(FR-2933): disable vitest cache in CI#7512

Open
nowgnuesLee wants to merge 1 commit into
mainfrom
05-20-chore_fr-2933_disable_vitest_cache_in_ci
Open

chore(FR-2933): disable vitest cache in CI#7512
nowgnuesLee wants to merge 1 commit into
mainfrom
05-20-chore_fr-2933_disable_vitest_cache_in_ci

Conversation

@nowgnuesLee
Copy link
Copy Markdown
Contributor

@nowgnuesLee nowgnuesLee commented May 20, 2026

Resolves #7510 (FR-2933)

Adds --no-cache to the three pnpm exec vitest run --coverage invocations in .github/workflows/vitest.yml (jobs react-vitest, backend-ai-ui-vitest, root-vitest).

Vitest's default on-disk cache (node_modules/.vitest/) is unnecessary in CI — each run starts from a fresh checkout, so the cache cannot meaningfully speed up runs, and a partial cache restore could mask test-selection or skip changes. Disabling it on CI only makes runs explicitly reproducible while keeping local-dev caching unchanged (no edits to any vitest.config.ts).

Verification

  • bash scripts/verify.sh — no new failures from this change (the YAML edit is not on any TypeScript, Relay, or Vite path). Pre-existing failures on main (TS ERR_UNKNOWN_BUILTIN_MODULE, Vite warmup paths) are unrelated.
  • Workflow YAML is exercised by GitHub Actions on PR open.

Copy link
Copy Markdown
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nowgnuesLee nowgnuesLee marked this pull request as ready for review May 20, 2026 05:26
Copilot AI review requested due to automatic review settings May 20, 2026 05:26
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves CI reproducibility by disabling Vitest’s on-disk cache during GitHub Actions runs, ensuring test selection and execution are not influenced by any cached state.

Changes:

  • Add --no-cache to the React Vitest coverage run in CI.
  • Add --no-cache to the packages/backend.ai-ui Vitest coverage run in CI.
  • Add --no-cache to the root Vitest coverage run in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS ~10 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable vitest cache when running in CI

2 participants