fix: tag CEL Function return correct tag when tag and digest are present#69
Open
lukeelten wants to merge 1 commit intokyverno:mainfrom
Open
fix: tag CEL Function return correct tag when tag and digest are present#69lukeelten wants to merge 1 commit intokyverno:mainfrom
lukeelten wants to merge 1 commit intokyverno:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
+ Coverage 71.52% 71.58% +0.05%
==========================================
Files 79 79
Lines 2381 2386 +5
==========================================
+ Hits 1703 1708 +5
Misses 536 536
Partials 142 142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
realshuting
reviewed
Mar 25, 2026
Member
realshuting
left a comment
There was a problem hiding this comment.
Thanks @lukeelten for the contribution, this looks good overall!
Can you please address this semantic check issue?
db4fdc9 to
aeb70b3
Compare
Signed-off-by: Tobias Derksen <t.derksen@mailbox.org>
Author
|
Hi @realshuting , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR fixes a bug is the
tagCEL function which returns an empty string when a tag and a digest are present.Related issue
Fixes kyverno/kyverno#15273
Proposed Changes
The root issue can be found upstream in google/go-containerregistry#2069 but there has been no progress since more than a year.
To fix this issue, the edge case is detected in kyverno cel function and handled properly.
The special case can be removed when the bug has been fixed in upstream.
Checklist
Further Comments