Skip to content

fix: enhance IP address validation to include global unicast check #3084

Merged
kubesphere-prow[bot] merged 1 commit intokubesphere:mainfrom
redscholar:correct_ip
Apr 23, 2026
Merged

fix: enhance IP address validation to include global unicast check #3084
kubesphere-prow[bot] merged 1 commit intokubesphere:mainfrom
redscholar:correct_ip

Conversation

@redscholar
Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

etcd and kubelet need global or ula ip.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

none

Additional documentation, usage docs, etc.:


@kubesphere-prow kubesphere-prow Bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. labels Apr 23, 2026
@kubesphere-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redscholar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubesphere-prow kubesphere-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 23, 2026
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refines the IP address selection logic in pkg/variable/variable_get.go by incorporating IsGlobalUnicast() checks for both IPv4 and IPv6 addresses. These changes ensure that only routable addresses are selected, filtering out link-local addresses that are unsuitable for cluster communication. I have no additional feedback to provide as the existing review comments were purely evaluative and did not identify any issues or further improvements.

@redscholar redscholar added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2026
@kubesphere-prow kubesphere-prow Bot merged commit ee846ad into kubesphere:main Apr 23, 2026
7 checks passed
@redscholar redscholar deleted the correct_ip branch April 24, 2026 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant