fix: update chart downloading logic and improve digest handling in im…

[redscholar]

…age repository

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

none

Additional documentation, usage docs, etc.:

[kubesphere-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redscholar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [redscholar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sonarqubecloud]

Quality Gate failed

Failed conditions
53.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

[gemini-code-assist]

Code Review

This pull request refactors the Helm chart download process to support both OCI and standard HTTP repositories using helm pull and updates the image repository module to resolve manifest digests from tags using a local layout file. Feedback focuses on improving the robustness of these changes, specifically by handling missing tags in the layout file to avoid 500 errors, correcting log paths, quoting shell variables in Ansible tasks, and restoring idempotency checks to prevent redundant chart downloads.

[gemini-code-assist]

If the requestDigest (the tag) is not found in the layout file, actualDigest will be an empty string. This causes actualFilename to point to the directory itself. os.Stat will succeed on the directory, but os.ReadFile will subsequently fail with an error (e.g., "is a directory"), leading to a 500 Internal Server Error. It is more appropriate to return responseNotFound (404) when the tag cannot be resolved.

			actualDigest = tagDigest[requestDigest]
			if actualDigest == "" {
				return responseNotFound
			}
		}

[gemini-code-assist]

The error log should reference actualFilename instead of filename, as actualFilename is the path that the code attempted to read and failed.

Suggested change

	klog.V(4).ErrorS(err, "failed to read file", "filename", filename)
	klog.V(4).ErrorS(err, "failed to read file", "filename", actualFilename)

[gemini-code-assist]

Shell variables should be double-quoted to ensure the script handles URLs or versions containing spaces or special characters correctly.

    url="{{ .item.url }}"
    version="{{ .item.version }}"

[gemini-code-assist]

The transition from a copy task with a when condition to a command task has removed the idempotency check. helm pull will now be executed on every run, regardless of whether the chart already exists in the artifact directory. Consider adding a shell-level check to skip the download if the target file is already present to improve efficiency.