Skip to content

frontend: Dialog: move useCallback before early return to fix rules-of-hooks #5208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
illume merged 1 commit into from
Apr 25, 2026
+9 −11
Merged

frontend: Dialog: move useCallback before early return to fix rules-of-hooks #5208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions frontend/src/components/common/Dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,23 +45,21 @@ export interface OurDialogTitleProps extends DialogTitleProps {
*/
export function DialogTitle(props: OurDialogTitleProps) {
const { children, focusTitle, buttons, disableTypography = false, id, ...other } = props;
const focusedRef = React.useCallback(
(node: HTMLElement | null) => {
if (node !== null && focusTitle) {
node.setAttribute('tabindex', '-1');
node.focus();
}
},
[focusTitle]
);

// Don't render heading if there's no content to avoid empty heading violations
if (!children && (!buttons || buttons.length === 0)) {
return null;
}

// eslint-disable-next-line react-hooks/rules-of-hooks
const focusedRef = React.useCallback((node: HTMLElement) => {
if (node !== null) {
if (focusTitle) {
node.setAttribute('tabindex', '-1');
node.focus();
}
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);

return (
<MuiDialogTitle style={{ display: 'flex' }} {...other}>
<Grid container justifyContent="space-between" alignItems="center">
Expand Down
Loading