frontend: Fix GRPCRoute section ID and remove debug console.log#5052
frontend: Fix GRPCRoute section ID and remove debug console.log#5052NAME-ASHWANIYADAV wants to merge 2 commits intokubernetes-sigs:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: NAME-ASHWANIYADAV The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @NAME-ASHWANIYADAV! |
|
/assign @sniok |
|
@sniok Hey! Could you share a rough estimate of when you might be able to review this PR? Thanks 🙂 |
|
/test ? |
|
@NAME-ASHWANIYADAV: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
sniok
left a comment
There was a problem hiding this comment.
hi, could you please resolve merge conflicts
aaadc16 to
4b2dde0
Compare
|
@sniok i have resolved the conflict may you re-review it again |
sniok
left a comment
There was a problem hiding this comment.
hi, sorry but the commit says Remove debug console.log from production code but the change is different, it modifies what gets logged. could you please update the commit message for that change?
4b2dde0 to
2250194
Compare
|
@sniok Updated commit message, please re-review |
3b3be79 to
2250194
Compare
Fixes #5051
Summary
This PR fixes a copy-paste bug in GRPCRouteDetails where the section ID
was incorrectly set to
headlamp.httproute-parentrefsinstead ofheadlamp.grpcroute-parentrefs. This also removes leftover debugconsole.logstatements from production code across several files.Changes
Bug fix:
headlamp.httproute-parentrefsto
headlamp.grpcroute-parentrefsDebug log cleanup:
console.login remove() that loggedevery DELETE request URL and options
console.login RuleBackendRefsconsole.login onChange handlerconsole.logtoconsole.errorforport forward start errors
console.logtoconsole.errorforCRD fetch errors
Steps to Test
console.logoutput from the modified filesconsole.errorin portforwardand sidebar components