Skip to content

✨ selfmanaged: fixed instance category for instances using for controlplane, etcd, loadbalancer#68

Merged
Horiodino merged 2 commits intomainfrom
enhancement/ksctl-instancetype
Mar 23, 2025
Merged

✨ selfmanaged: fixed instance category for instances using for controlplane, etcd, loadbalancer#68
Horiodino merged 2 commits intomainfrom
enhancement/ksctl-instancetype

Conversation

@dipankardas011
Copy link
Copy Markdown
Member

@dipankardas011 dipankardas011 commented Mar 23, 2025 •
edited
Loading

🗒️ Changelog

  • Self managed
    • Controlplane: ComputeIntensive
    • Etcd: MemoryIntensive
    • Loadbabalancer: GeneralPurpose
    • WorkerNode: User defined (ComputeIntensive | MemoryIntensive | GeneralPurpose | Burstable)
  • Managed
    • Controlplane: Managed so no option
    • WorkerNode: User defined (ComputeIntensive | MemoryIntensive | GeneralPurpose | Burstable)

🏋🏼 Issues

✅ Completed Issues

  • Fixes:

📎 Related Issues

  • Related to:

🚀 Task List

  • [ ]
  • [ ]

🔍 Review Checklist

  • Code follows project style guidelines
  • Added/updated tests
  • Ran tests locally
  • Updated documentation
  • Checked Contribution Guidelines

📸 Screenshots/Recordings

Aws Azure
image image

📌 Additional Notes

💡 PR best practices
  • Keep changes focused and atomic
  • Update tests and documentation
  • Check for conflicts with main branch
  • Respond promptly to review comments
  • Follow project coding standards
  • Make sure you are using pre-commit for that run this command $ pre-commit install

@dipankardas011
made some fixed instancetype category for controlplane, etcd, lb
3ac8c13 
Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
@dipankardas011 dipankardas011 marked this pull request as draft March 23, 2025 12:54
@dipankardas011
fixed the logic of handler instancetype
50540ff 
Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
@dipankardas011 dipankardas011 changed the title made some fixed instancetype category for controlplane, etcd, lb ✨ selfmanaged: fixed instance category for instances using for controlplane, etcd, loadbalancer Mar 23, 2025
@dipankardas011 dipankardas011 marked this pull request as ready for review March 23, 2025 13:12
@Horiodino Horiodino added this pull request to the merge queue Mar 23, 2025
Merged via the queue into main with commit 7bd2e3b Mar 23, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Horiodino Horiodino Horiodino approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dipankardas011 @Horiodino