Skip to content

fix(prometheus): return firing_alerts from critical_alerts() #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NETIZEN-11 wants to merge 2 commits into from
+2 −2
Closed

fix(prometheus): return firing_alerts from critical_alerts() #1218

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d2dc55
fix(prometheus): return firing_alerts from critical_alerts()
NETIZEN-11 Mar 31, 2026
bacf0cb
Merge branch 'main' into fix/prometheus-critical-alerts-return
NETIZEN-11 Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions krkn/prometheus/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#!/usr/bin/env python
#
# Copyright 2025 The Krkn Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -178,8 +180,6 @@ def critical_alerts(

if not firing_alerts:
logging.info("No critical alerts are firing!!")


def metrics(
prom_cli: KrknPrometheus,
elastic: KrknElastic,
Expand Down
Loading