Fixed accumulation phase where one point was tried to accumulate multiple times#176
Open
AzaelCicero wants to merge 1 commit intokoide3:masterfrom
Open
Fixed accumulation phase where one point was tried to accumulate multiple times#176AzaelCicero wants to merge 1 commit intokoide3:masterfrom
AzaelCicero wants to merge 1 commit intokoide3:masterfrom
Conversation
…x_bucket_scan_count times.
AzaelCicero
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking the loop of the accumulation phase when the corresponding voxel for the point is found. Without it, the point was attempted to accumulate up to max_bucket_scan_count times, once to correct the voxel successfully, and the rest to various other voxels where it was rejected due to a comparison of the voxel coordinates. The problem is with points assigned to voxel [0, 0, 0], as the empty bins are marked as coords [0, 0, 0] and -1 table index. So when a point normally assigned to voxel [0,0,0] is tried to accumulate to an empty bin, then CUDA access memory is thrown.