You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was using this repo as a component for another project of mine, and I found that the logic in the core.js file (especially the getNodeByRjsfId) could be simplified if we just change the renaming style of similar Menu elements.
Since the node's rjsf-id uses _ as a separator between properties (templatename_parentname_...), I think using a different separator would be better.
P.S.: Really great work on building this form builder. Great code. 🙏
Thanks for the interest in this project.
The purpose of the complex logic in getNodeByRjsfId is to support _ as best as it can, since it's quite a commonly used character in the filed name.
The root issue is in rjsf. They way how it generate the id is problematic, for example:
My main focus at the moment is to move toward gravel-form. I'll still maintain the support for rjsf such as upgrading packages occasionally but will no long adding new feature to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I was using this repo as a component for another project of mine, and I found that the logic in the
core.jsfile (especially thegetNodeByRjsfId) could be simplified if we just change the renaming style of similar Menu elements.Since the node's rjsf-id uses
_as a separator between properties (templatename_parentname_...), I think using a different separator would be better.P.S.: Really great work on building this form builder. Great code. 🙏