Skip to content

fix artists metadata#116

Open
AldeToro wants to merge 3 commits intokmille:masterfrom
AldeToro:fix-artists-names
Open

fix artists metadata#116
AldeToro wants to merge 3 commits intokmille:masterfrom
AldeToro:fix-artists-names

Conversation

@AldeToro
Copy link
Copy Markdown

Fix for artists names in metadata to resolve issue #115

Modified filename to have album's artist name instead
Modified ID3v1 artist metadata for album's artist (main artist) instead of song's ART_NAME value
Modified ID3v2 album's artist metadata for album's artist (main artist) instead of song's ART_NAME value
Modified ID3v2 artists metadata for a concatenation of all artists of the song

(It's my first pull request ever, yay \o/)

…adata, list of artists in artists metadata
@kmille
Copy link
Copy Markdown
Owner

kmille commented Nov 24, 2024

Can you give me a song where the PR fixes the problem. I also had problems in the past (#110)

@AldeToro
Copy link
Copy Markdown
Author

You can use the one used in example in the issue #115
Scooter - My Gabber / https://deezer.page.link/Hr4uE6ewKMLxkMaR7

@AldeToro
Copy link
Copy Markdown
Author

I also changed the used deezer URL from german to english because some artists names were translated to german

@kmille
Copy link
Copy Markdown
Owner

kmille commented Feb 13, 2026

Hey
sorry I never found to really dig into this. I just merged #201, which is an updated version of your PR (resolves current conflicts). Now the filename problem is solved. Your MR also updates the ID3 tags. I will keep this open and try to inlucde your changes in the future. Feel free to rebase if you find time, but I rewrote this piece of code a lot. Now a library is used to write the metadata to disk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants