Skip to content

replace IS_NODE_TITLE with a tag#234

Open
Eddykasp wants to merge 3 commits intomasterfrom
mka/nodeTitleTags
Open

replace IS_NODE_TITLE with a tag#234
Eddykasp wants to merge 3 commits intomasterfrom
mka/nodeTitleTags

Conversation

@Eddykasp
Copy link
Copy Markdown
Member

No description provided.

@Eddykasp Eddykasp added the requires client change This change is linked to some change on the client side implementation in klighd-vscode label Jul 24, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the IS_NODE_TITLE property with a semantic filter tag approach. The change moves from using a boolean property in KlighdProperties to using a SemanticFilterTag in a new KlighdTags utility class.

  • Removes the IS_NODE_TITLE boolean property from KlighdProperties
  • Creates a new KlighdTags utility class containing predefined semantic tags
  • Introduces IS_NODE_TITLE as a SemanticFilterTag instead of a boolean property

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
KlighdTags.java New utility class containing the IS_NODE_TITLE semantic filter tag
KlighdProperties.java Removes the deprecated IS_NODE_TITLE boolean property

Comment on lines +27 to +34
public class KlighdTags {

/**
* Determines whether a sub-KRendering can be interpreted as a title for a node.
* By default no rendering is seen as a title.
*/
public static final SemanticFilterTag IS_NODE_TITLE = new SemanticFilterTag("isNodeTitle");

Copy link

Copilot AI Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider making this class final and adding a private constructor to prevent instantiation, since it only contains static constants.

Suggested change
public class KlighdTags {
/**
* Determines whether a sub-KRendering can be interpreted as a title for a node.
* By default no rendering is seen as a title.
*/
public static final SemanticFilterTag IS_NODE_TITLE = new SemanticFilterTag("isNodeTitle");
public final class KlighdTags {
/**
* Private constructor to prevent instantiation.
*/
private KlighdTags() {
// Prevent instantiation
}
/**
* Determines whether a sub-KRendering can be interpreted as a title for a node.
* By default no rendering is seen as a title.
*/
public static final SemanticFilterTag IS_NODE_TITLE = new SemanticFilterTag("isNodeTitle");

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires client change This change is linked to some change on the client side implementation in klighd-vscode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants