Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the IS_NODE_TITLE property with a semantic filter tag approach. The change moves from using a boolean property in KlighdProperties to using a SemanticFilterTag in a new KlighdTags utility class.
- Removes the
IS_NODE_TITLEboolean property fromKlighdProperties - Creates a new
KlighdTagsutility class containing predefined semantic tags - Introduces
IS_NODE_TITLEas aSemanticFilterTaginstead of a boolean property
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| KlighdTags.java | New utility class containing the IS_NODE_TITLE semantic filter tag |
| KlighdProperties.java | Removes the deprecated IS_NODE_TITLE boolean property |
Comment on lines
+27
to
+34
| public class KlighdTags { | ||
|
|
||
| /** | ||
| * Determines whether a sub-KRendering can be interpreted as a title for a node. | ||
| * By default no rendering is seen as a title. | ||
| */ | ||
| public static final SemanticFilterTag IS_NODE_TITLE = new SemanticFilterTag("isNodeTitle"); | ||
|
|
There was a problem hiding this comment.
Consider making this class final and adding a private constructor to prevent instantiation, since it only contains static constants.
Suggested change
| public class KlighdTags { | |
| /** | |
| * Determines whether a sub-KRendering can be interpreted as a title for a node. | |
| * By default no rendering is seen as a title. | |
| */ | |
| public static final SemanticFilterTag IS_NODE_TITLE = new SemanticFilterTag("isNodeTitle"); | |
| public final class KlighdTags { | |
| /** | |
| * Private constructor to prevent instantiation. | |
| */ | |
| private KlighdTags() { | |
| // Prevent instantiation | |
| } | |
| /** | |
| * Determines whether a sub-KRendering can be interpreted as a title for a node. | |
| * By default no rendering is seen as a title. | |
| */ | |
| public static final SemanticFilterTag IS_NODE_TITLE = new SemanticFilterTag("isNodeTitle"); |
Eddykasp
commented
Jul 28, 2025
…il/KlighdProperties.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.