Conversation
… again (@accessors KGraphLanguageClient client is null)
…es to all actions aswell as the sendable options
Also generates the correct text file as output but client is still null and thus transmittion is not possible!
# Conflicts: # plugins/de.cau.cs.kieler.klighd/src/de/cau/cs/kieler/klighd/util/KlighdProperties.java
Also added some more Actions
Added support for trigger and effect creation
soerendomroes
left a comment
soerendomroes
left a comment
There was a problem hiding this comment.
klighd.lsp cannot depend on SCCharts. Try using a service interface instead.
| <buildSpec> | ||
| <buildCommand> | ||
| <name>org.eclipse.jdt.core.javabuilder</name> | ||
| <name>org.eclipse.xtext.ui.shared.xtextBuilder</name> |
| @Inject | ||
|
|
||
| @Inject | ||
| protected ScchartStructuredProgrammingActionHandler scchartsStructuredActionHandler |
There was a problem hiding this comment.
Is this the only change and the rest are just write-space changes?
The name suggests that it should not be in here since it sounds SCCharts-specific, maybe you should use a service interface for this.
If you use SCCharts in a class name, also capitalize it the same way as SCCharts.
| org.eclipse.xtext.ide;bundle-version="2.21.0", | ||
| org.eclipse.xtext.xbase;bundle-version="2.21.0" | ||
| org.eclipse.xtext.xbase;bundle-version="2.21.0", | ||
| de.cau.cs.kieler.sccharts;bundle-version="1.4.0" |
There was a problem hiding this comment.
klighd.lsp cannot and should never have an SCCharts dependency.
| import de.cau.cs.kieler.klighd.kgraph.KNode | ||
| import de.cau.cs.kieler.klighd.kgraph.KEdge | ||
| import de.cau.cs.kieler.klighd.internal.util.KlighdInternalProperties | ||
| import de.cau.cs.kieler.sccharts.State |
There was a problem hiding this comment.
Again, no SCCharts dependencies in here.
| import de.cau.cs.kieler.klighd.kgraph.KEdge | ||
| import de.cau.cs.kieler.klighd.internal.util.KlighdInternalProperties | ||
| import de.cau.cs.kieler.sccharts.State | ||
| import de.cau.cs.kieler.kexpressions.impl.ValuedObjectImpl |
There was a problem hiding this comment.
Also no kexpressions dependencies.
| * | ||
| * http://rtsys.informatik.uni-kiel.de/kieler | ||
| * | ||
| * Copyright ${year} by |
| } | ||
|
|
||
| /*Method to add hirarchical behavior to a node */ | ||
| def addHirachicalNode(AddHierarchicalStateAction action, String clientId, KGraphDiagramServer server) { |
| factory = new SCChartsFactoryImpl() | ||
| } | ||
|
|
||
| /*simply sets the range to be the files size. */ |
There was a problem hiding this comment.
All the methods below do not have a javadoc but only a comment in front of them.
| Bundle-Activator: de.cau.cs.kieler.klighd.KlighdPlugin | ||
| Export-Package: de.cau.cs.kieler.klighd, | ||
| de.cau.cs.kieler.klighd.actions, | ||
| de.cau.cs.kieler.klighd.filtering, |
There was a problem hiding this comment.
These are the changes by mka, correct?
| /** | ||
| * This class holds the keyinformation what inputs need to be done on the client for a specific | ||
| * action. The label is displayed to the user in the contextmenu. The kind is the action kind. | ||
| * Mergable is when multiple things are selected and it can be done for all of them The InputType |
2 participants
@soerendomroes