Skip to content
This repository was archived by the owner on Mar 24, 2023. It is now read-only.

Printing felt representation of types (currently on top of #65)#66

Draft
DomHenderson wants to merge 27 commits intokeep-starknet-strange:mainfrom
NethermindEth:printing
Draft

Printing felt representation of types (currently on top of #65)#66
DomHenderson wants to merge 27 commits intokeep-starknet-strange:mainfrom
NethermindEth:printing

Conversation

@DomHenderson
Copy link
Copy Markdown

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing
  • Other (please describe):

What is the current behavior?

Currently we print either the raw value representing the felt return, or each field of the presumed to be non-nested struct. Additionally print_felt and print_double_felt are always included in the output, and felt values can be printed that are outside the range of [0, PRIME)

Issue Number: N/A

What is the new behavior?

  • Main will print the felt representation of arbitrarily nested complex types
  • print_felt and print_double_felt will be included in the code iff a flag is passed to the cli
  • felt values that are printed from main will be wrapped. print_felt and print_double_felt will print raw values for debugging purposes

Does this introduce a breaking change?

  • Yes
  • No

Other information

Relevant files to look at in files changed are process/statements.rs and statements_processing/print/print_felt_representation.rs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant