feat: require explicit targetValue in scaling metric specs (#1597)

Author: linkvt

config/crd/bases/http.keda.sh_interceptorroutes.yaml

@@ -159,11 +159,12 @@ spec:
                     description: Scale based on concurrent request count.
                     properties:
                       targetValue:
-                        default: 100
                         description: Target concurrent request count per replica.
                         format: int32
                         minimum: 1
                         type: integer
+                    required:
+                    - targetValue
                     type: object
                   requestRate:
                     description: Scale based on request rate.
@@ -173,7 +174,6 @@ spec:
                         description: Bucket size for rate calculation within the window.
                         type: string
                       targetValue:
-                        default: 100
                         description: Target request rate per replica.
                         format: int32
                         minimum: 1
@@ -183,6 +183,8 @@ spec:
                         description: Sliding time window over which the request rate
                           is calculated.
                         type: string
+                    required:
+                    - targetValue
                     type: object
                 type: object
                 x-kubernetes-validations:

operator/apis/http/v1beta1/interceptorroute_types.go

@@ -63,10 +63,8 @@ type RoutingRule struct {
 // ConcurrencyTargetSpec defines concurrency-based scaling.
 type ConcurrencyTargetSpec struct {
 	// Target concurrent request count per replica.
-	// +kubebuilder:default=100
 	// +kubebuilder:validation:Minimum=1
-	// +optional
-	TargetValue int32 `json:"targetValue,omitzero"`
+	TargetValue int32 `json:"targetValue"`
 }
 
 // RequestRateTargetSpec defines rate-based scaling.
@@ -76,10 +74,8 @@ type RequestRateTargetSpec struct {
 	// +optional
 	Granularity metav1.Duration `json:"granularity,omitzero"`
 	// Target request rate per replica.
-	// +kubebuilder:default=100
 	// +kubebuilder:validation:Minimum=1
-	// +optional
-	TargetValue int32 `json:"targetValue,omitzero"`
+	TargetValue int32 `json:"targetValue"`
 	// Sliding time window over which the request rate is calculated.
 	// +kubebuilder:default="1m"
 	// +optional