Skip to content

Commit 36bb1a3

Browse files
authored
feat: log deprecation warning for HTTPScaledObject (#1595)
1 parent de6052b commit 36bb1a3

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

operator/controllers/http/httpscaledobject_controller.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121
"fmt"
2222
"net"
2323
"strconv"
24+
"sync"
2425
"time"
2526

2627
kedav1alpha1 "github.com/kedacore/keda/v2/apis/keda/v1alpha1"
@@ -49,6 +50,8 @@ type HTTPScaledObjectReconciler struct {
4950

5051
ExternalScalerConfig config.ExternalScaler
5152
BaseConfig config.Base
53+
54+
deprecationWarned sync.Map
5255
}
5356

5457
// +kubebuilder:rbac:groups=http.keda.sh,resources=httpscaledobjects,verbs=get;list;watch;create;update;patch;delete
@@ -84,6 +87,11 @@ func (r *HTTPScaledObjectReconciler) Reconcile(ctx context.Context, req ctrl.Req
8487
return ctrl.Result{}, finalizeScaledObject(ctx, logger, r.Client, httpso)
8588
}
8689

90+
// TODO(v1): remove before v1 release
91+
if _, alreadyWarned := r.deprecationWarned.LoadOrStore(req.String(), true); !alreadyWarned {
92+
logger.Info("WARNING: HTTPScaledObject is deprecated and will be removed in a future release, migrate to InterceptorRoute + ScaledObject: https://keda.sh/http-add-on/0.14/operations/migrate-httpscaledobject-to-interceptorroute/")
93+
}
94+
8795
// ensure finalizer is set on this resource
8896
if err := ensureFinalizer(ctx, logger, r.Client, httpso); err != nil {
8997
return ctrl.Result{}, err

0 commit comments

Comments
 (0)