chore(ci): adopt setup-vcpkg composite action#244
Merged
Conversation
Replace inline vcpkg clone/bootstrap/cache steps (54 lines) with the reusable composite action from kcenon/common_system/.github/actions/setup-vcpkg. Changes: - Remove 5 inline vcpkg setup steps (Cache, Setup Unix/Windows, Determine commit) - Add single composite action step with project-specific cache key - Update vcpkg binary path to use VCPKG_ROOT env var - Update Windows CMake toolchain to use CMAKE_TOOLCHAIN_FILE env var - Simplify vcpkg_installed cache key (pinned commit via action removes need for dynamic hash) Part of kcenon/common_system#512
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrate messaging_system CI workflow from inline vcpkg setup logic to the reusable
composite action at
kcenon/common_system/.github/actions/setup-vcpkg/.Change Type
Affected Components
.github/workflows/ci.yml— vcpkg setup steps in thebuildjobWhy
Problem Solved
The inline vcpkg setup duplicates 54 lines of clone/bootstrap/cache logic that is
already encapsulated in the ecosystem composite action. This creates maintenance
burden — a bug fix in setup logic would require separate PRs in each repo.
Related Issues
Benefits
Where
Files Changed
.github/workflows/ci.ymlSpecific Changes
kcenon/common_system/.github/actions/setup-vcpkg@mainvcpkgbinary path to${{ env.VCPKG_ROOT }}/vcpkg${{ env.CMAKE_TOOLCHAIN_FILE }}vcpkg_installedcache key (removed dynamic commit hash)How
Implementation Details
The composite action handles:
d90a9b15VCPKG_ROOTandCMAKE_TOOLCHAIN_FILEenvironment variablesThe
build-without-networkjob is unchanged — it does not use vcpkg.Test Plan
Breaking Changes
None — only CI infrastructure change, no source code modifications.