Conversation
…hanges (Issue #223) - Update transport_interface to match actual header API: disconnect() returns VoidResult, rename state() to get_state(), replace send_async() with send_binary(), add statistics methods - Replace transport_options with transport_config/transport_statistics - Rewrite websocket_transport with proper config and topic methods - Rewrite http_transport with http_content_type and config structs - Replace resilient_transport with retry_config, circuit_breaker_config, resilient_transport_config, and resilience_statistics from Issue #221 - Add messaging_error_category and make_messaging_error_code to core partition from Issue #229 - Add health check adapter exports (messaging_health_check, queue_health_check, transport_health_check) from Issue #222 - Add composite check and registration helper exports
22 tasks
- Fix INTERFACE library target handling in UnifiedDependencies.cmake (use INTERFACE keyword instead of PUBLIC for INTERFACE targets) - Link messaging_system_modules to messaging_system_core for proper upstream include path propagation during dependency scanning - Remove non-existent kcenon.logger module import (logging is part of kcenon.common:logging partition) - Replace kcenon.database import with kcenon.monitoring (database_system has upstream CMake module build bug) - Use foreach loop for cleaner upstream module target linking
Owner
Author
Module Build Verification ResultsConfiguration Summary
Issues Found & Fixed
Build Results
ConclusionThe messaging_system module files are correctly configured and scan successfully. Full end-to-end module compilation is blocked by upstream module file bugs in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #223
Summary
integration.cppmtransport types with actual header API signatures (transport_interface, websocket_transport, http_transport, resilient_transport)core.cppm(messaging_error_category, make_messaging_error_code from Issue [Refactor] Define messaging_error_category and typed error codes #229)integration.cppm(retry_config, circuit_breaker_config, resilience_statistics from Issue [Refactor] Replace local circuit breaker with common_system resilience module #221)integration.cppm(messaging_health_check, queue_health_check, transport_health_check from Issue [Refactor] Integrate common_system health monitoring API #222)Changes
core.cppmmessaging_error_categoryclass andmake_messaging_error_code()factory function after the existing error codes sectionintegration.cppmtransport_optionswithtransport_config+transport_statisticsstructs matchingtransport_interface.hdisconnect()to returnVoidResult, renamedstate()toget_state(), replacedsend_async()withsend_binary(), addedset_binary_handler()/set_state_handler(), addedget_statistics()/reset_statistics()websocket_transport_config, includes topic subscription methods (subscribe,unsubscribe,unsubscribe_all,get_subscriptions),send_text(),ping(),set_disconnect_handler()http_content_typeenum,http_transport_config,post()/get()methods,set_header()/remove_header()retry_config,resilient_transport_config,resilience_statistics, circuit breaker control methods, PIMPL patternmap_health_status(),messaging_health_check,queue_health_check,transport_health_check,create_messaging_composite_check(),register_messaging_health_checks()<format>,<map>,<set>to global module fragmentTest Plan
MESSAGING_BUILD_MODULES=ON(requires CMake 3.28+ and upstream module targets in CI)