Fix calculated data overwrite issue#552
Conversation
|
Thank you for the PR but what does this solve? Overriding it this way is intentional, configuration set in popover is supposed to override the global configuration of driver |
|
Hi there, For example: the value of "progessText" field of "1 of 5" gets overwritten with template |
|
I agree that it is wrong approach to do the overriding of the data the way suggested in this PR. It breaks the intention. However, rufus87 is correct with the issue, but the bug is in the Driver class itself by doing the calculation of the text before the spread is done. I did my own PR as a fun part of Hacktoberfest. I know that it is late for Hacktoberfest and this project is not part of it. So please label my contribution with the |
The calculated step configuration gets overwritten by the original step configuration. This small PR fixes it.