Select only visible elements for the tour#441
Open
trymebytes wants to merge 2 commits intokamranahmedse:masterfrom
Open
Select only visible elements for the tour#441trymebytes wants to merge 2 commits intokamranahmedse:masterfrom
trymebytes wants to merge 2 commits intokamranahmedse:masterfrom
Conversation
|
Does it also work for 'display:none' elements? |
onkar-giram
approved these changes
Nov 28, 2023
onkar-giram
approved these changes
Dec 12, 2023
Author
|
I'm unable to merge this PR because I don't have write access. |
EtienneS76
approved these changes
Apr 11, 2024
|
@kamranahmedse do you think it's possible to merge this feature ? It would be greatly appreciated to have this security. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The tour is activated for the first element that matches the selector and causes a problem when the element is not visible or is hidden.
Solution
In this PR, I try to ensure that the tour is activated for the visible element that matches the selector. As a result the tour will not be activated for hidden elements.