Open
Conversation
ListOSResourcesForAdoption only filtered by floating IP address and tags, without considering the floating network or project. Adoption could match a floating IP on the wrong network when concurrent tests created floating IPs with the same address on different external networks. Resolve FloatingNetworkRef or FloatingSubnetRef to obtain the OpenStack network ID and include it in the list filter. Also include ProjectID when ProjectRef is set. Collapse floatingipCreateActuator into floatingipActuator since the split is no longer needed now that k8sClient is on the base actuator.
ListOSResourcesForAdoption only filtered by name. Resolve NetworkRef and include NetworkID, the immutable CIDR and IPVersion fields, and ProjectID when set in the list filter to prevent adopting a subnet on the wrong network or with the wrong addressing.
ListOSResourcesForAdoption only filtered by name. Resolve NetworkRef and include NetworkID, MACAddress when specified (immutable, globally unique), and ProjectID when set in the list filter to prevent adopting a port on the wrong network.
ListOSResourcesForAdoption only filtered by name and description. Resolve PortRef and include PortID, and ProjectID when set, in the list filter to prevent adopting a trunk associated with the wrong parent port.
ListOSResourcesForAdoption only filtered by name and tags. Resolve DomainRef when set and include DomainID in the list filter to prevent adopting a project in the wrong domain.
ListOSResourcesForAdoption only filtered by name. Resolve DomainRef when set and include DomainID in the list filter to prevent adopting a user in the wrong domain.
ListOSResourcesForAdoption only filtered by name. Resolve DomainRef when set and include DomainID in the list filter to prevent adopting a group in the wrong domain.
ListOSResourcesForAdoption only filtered by name. Include the immutable IPVersion field and ProjectID when set in the list filter to prevent adopting an address scope with the wrong IP version or from the wrong project.
ListOSResourcesForAdoption only filtered by name. Resolve ProjectRef when set and include ProjectID and the Stateful field in the list filter to prevent adopting a security group from the wrong project or with the wrong stateful/stateless behavior.
ListOSResourcesForAdoption only filtered by name. Resolve ProjectRef when set and include ProjectID in the list filter to prevent adopting a network from the wrong project with admin-scoped credentials.
ListOSResourcesForAdoption only filtered by name. Resolve ProjectRef when set and include ProjectID and the immutable Distributed field in the list filter to prevent adopting a router from the wrong project or with the wrong topology. Collapse routerCreateActuator into routerActuator since the split is no longer needed now that k8sClient is on the base actuator.
Include the immutable Policy field in the client-side adoption filter to prevent adopting a server group with the wrong scheduling policy (e.g. affinity vs anti-affinity).
mandre
force-pushed
the
fix-fip-adoption
branch
from
31eba3d to
8fb26f7
Compare
mandre
changed the title
Contributor
|
LGTM |
dlaw4608
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tighten
ListOSResourcesForAdoptionacross all controllers to include parent resource IDs, immutable identifying fields, and project/domain scoping in the adoption filter.Fixes #757